HungerGameSSS

[4.5.9] — Bug Fix Pass 5 (2026-04-24)

Fixed — 3 bugs across 3 files

High

• BUG-BASE-01 · BaseAbility — validateCanUse() uses wrong permission node hg.admin instead of hoplitebr.admin (BaseAbility.java) validateCanUse() granted the admin bypass with player.hasPermission("hg.admin"). The correct node — defined in plugin.yml and fixed for commands in 4.1 (bug M-07) — is hoplitebr.admin. Any operator who granted the hoplitebr.admin permission explicitly (without OP) received no bypass; conversely, hg.admin grants that had been assigned in a permissions plugin incorrectly bypassed ability checks. Fix: changed check to player.hasPermission("hoplitebr.admin"). The || player.isOp() fallback is unchanged so vanilla OP still bypasses.

Medium

• BUG-CTX-01 · AbilityContext — no isCancelled() / setCancelled() API (AbilityContext.java) The AbilityContext object was fully immutable after construction. Abilities that need to signal downstream handlers to skip processing (e.g. two abilities sharing the same trigger chain) had no standard way to do so — each ability reimplemented ad-hoc boolean flags. Fix: added a mutable boolean cancelled field with isCancelled() and setCancelled(boolean) accessors. The field defaults to false. Abilities can now call ctx.setCancelled(true) to mark a context as consumed, and other abilities/listeners can check ctx.isCancelled() before acting.

• BUG-OD-02 · ObsidianDagger — deprecated getTargetBlock(null, range) + 1-tick meteor trail task + hardcoded sendMessage calls (ObsidianDagger.java) Three independent issues in performRightClick:

  1. player.getTargetBlock(null, TARGET_DISTANCE) — passing null for the transparent-block set is deprecated in Paper 1.21 and emits a compile warning. Replaced with player.getTargetBlockExact(distance, FluidCollisionMode.NEVER) with a rayTraceBlocks primary path for accurate targeting.
  2. The meteor particle trail BukkitRunnable ran at period 1L (every tick). A falling meteor moves slowly enough that 2L (every 2 ticks) produces visually identical results at half the server-side task overhead.
  3. Two player.sendMessage("§...") calls bypassed the Adventure component API (italic rendering issue) and the i18n system. Replaced with player.sendActionBar(Component) using LegacyComponentSerializer, consistent with the pattern used throughout other abilities since 4.5.5.

Changed

• pom.xml — version 4.5.8 → 4.5.9.
• plugin.yml — version 4.5.8 → 4.5.9; description updated.

---